svn commit: r365724 - in head/stand: ficl ficl/powerpc powerpc/ofw

[Gunther Nikl]

Brandon Bergren <bdragon at FreeBSD.org> wrote:

> Author: bdragon
> Date: Mon Sep 14 15:48:30 2020
> New Revision: 365724
> URL: https://svnweb.freebsd.org/changeset/base/365724
> 
> [snip]
>
> Modified: head/stand/ficl/ficl.h
> ==============================================================================
> --- head/stand/ficl/ficl.h	Mon Sep 14 15:20:37 2020
> (r365723) +++ head/stand/ficl/ficl.h	Mon Sep 14 15:48:30
> 2020	(r365724) @@ -249,7 +249,7 @@ typedef struct
> ficl_system_info FICL_SYSTEM_INFO; ** complement of false... that
> unifies logical and bitwise operations ** nicely.
>  */
> -#define FICL_TRUE  ((unsigned long)~(0L))
> +#define FICL_TRUE  ((FICL_UNS)~(0LL))

This looks strange. The define should be written as (~(FICL_UNS)0).
The size suffix is superfluous if the value is casted anyway.

>  #define FICL_FALSE (0)
>  #define FICL_BOOL(x) ((x) ? FICL_TRUE : FICL_FALSE)
>  
> 

Regards,
Gunther