svn commit: r365434 - stable/12/sys/netinet6

[Kyle Evans]

Author: kevans
Date: Mon Sep  7 23:20:02 2020
New Revision: 365434
URL: https://svnweb.freebsd.org/changeset/base/365434

Log:
  MFC r364982: ipv6: quit dropping packets looping back on p2p interfaces
  
  PR:		247718

Modified:
  stable/12/sys/netinet6/ip6_forward.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/netinet6/ip6_forward.c
==============================================================================
--- stable/12/sys/netinet6/ip6_forward.c	Mon Sep  7 21:37:16 2020	(r365433)
+++ stable/12/sys/netinet6/ip6_forward.c	Mon Sep  7 23:20:02 2020	(r365434)
@@ -257,24 +257,8 @@ again2:
 	 * modified by a redirect.
 	 */
 	if (V_ip6_sendredirects && rt->rt_ifp == m->m_pkthdr.rcvif && !srcrt &&
-	    (rt->rt_flags & (RTF_DYNAMIC|RTF_MODIFIED)) == 0) {
-		if ((rt->rt_ifp->if_flags & IFF_POINTOPOINT) != 0) {
-			/*
-			 * If the incoming interface is equal to the outgoing
-			 * one, and the link attached to the interface is
-			 * point-to-point, then it will be highly probable
-			 * that a routing loop occurs. Thus, we immediately
-			 * drop the packet and send an ICMPv6 error message.
-			 *
-			 * type/code is based on suggestion by Rich Draves.
-			 * not sure if it is the best pick.
-			 */
-			icmp6_error(mcopy, ICMP6_DST_UNREACH,
-				    ICMP6_DST_UNREACH_ADDR, 0);
-			goto bad;
-		}
+	    (rt->rt_flags & (RTF_DYNAMIC|RTF_MODIFIED)) == 0)
 		type = ND_REDIRECT;
-	}
 
 	/*
 	 * Fake scoped addresses. Note that even link-local source or