svn commit: r365071 - in head/sys: net net/altq net/route net80211 netgraph netgraph/atm netgraph/atm/ccatm netgraph/atm/sscfu netgraph/atm/sscop netgraph/atm/uni netgraph/bluetooth/common netgraph...

[Ed Maste]

On Sat, 5 Sep 2020 at 16:41, Warner Losh <imp at bsdimp.com> wrote:
>
>> Fixed:
>> - *_FOREACH now has a space before (, equivalent to for (;;)
>
> Except pretty much everywhere we don't have a space there...

Why not? Why should TAILQ_FOREACH have a different style from a for loop?

> broke all alignment of variables and comments that were done.
> broke purposely outdented code in statistics function
> broke all err() calls to wrap too much

I had all of these under "indifferent" already, or are more examples
of already covered cases (e.g. what seems to be string argument
wrapping).

> extra headers still included.

This is probably not the job of a formatter though.

>> - function argument wrapping (see write_glyph_buf)
>> - leading indentation and args-per-line (print_font_info)
>
> An interesting experiment, but there's far more worse after than before. The rearranging of carefully aligned elements is an especially galling change for some people (myself included).

I disagree this is far worse. If we fixed the wrapping on the second
line of if/for conditions I'd say the benefit of letting tooling take
care of the formatting outweighs the perhaps slightly less appealing
formatting.