svn commit: r365054 - in head/sys: conf dev/sdhci

[Ian Lepore]

On Tue, 2020-09-01 at 17:27 +0100, Andrew Turner wrote:
> > On 1 Sep 2020, at 17:17, Marcin Wojtas <mw at FreeBSD.org> wrote:
> > 
> > Author: mw
> > Date: Tue Sep  1 16:17:21 2020
> > New Revision: 365054
> > URL: https://svnweb.freebsd.org/changeset/base/365054
> > 
> > Log:
> >  Introduce the SDHCI driver for NXP QorIQ Layerscape SoCs
> > 
> >  Implement support for an eSDHC controller found in NXP QorIQ
> > Layerscape SoCs.
> > 
> >  This driver has been tested with NXP LS1046A and LX2160A
> > (Honeycomb board),
> >  which is incompatible with the existing sdhci_fsl driver (aiming
> > at older
> >  chips from this family). As such, it is not intended as
> > replacement for
> >  the old driver, but rather serves as an improved alternative for
> > SoCs that
> >  support it.
> >  It comes with support for both PIO and Single DMA modes and
> > samples the
> >  clock from the extres clk API.
> > 
> >  Submitted by: Artur Rojek <ar at semihalf.com>
> >  Reviewed by: manu, mmel, kibab
> >  Obtained from: Semihalf
> >  Sponsored by: Alstom Group
> >  Differential Revision: https://reviews.freebsd.org/D26153
> > 
> > Added:
> >  head/sys/dev/sdhci/sdhci_fsl_fdt.c   (contents, props changed)
> > Modified:
> >  head/sys/conf/files
> > 
> > Modified: head/sys/conf/files
> > ===================================================================
> > ===========
> > --- head/sys/conf/files	Tue Sep  1 16:13:09 2020	(r365053)
> > +++ head/sys/conf/files	Tue Sep  1 16:17:21 2020	(r365054)
> > @@ -3058,6 +3058,7 @@ dev/scc/scc_dev_z8530.c		optiona
> > l scc
> > dev/sdhci/sdhci.c		optional sdhci
> > dev/sdhci/sdhci_fdt.c		optional sdhci fdt
> > dev/sdhci/sdhci_fdt_gpio.c	optional sdhci fdt gpio
> > +dev/sdhci/sdhci_fsl_fdt.c	optional sdhci fdt gpio
> 
> This looks wrong. It should be using an NXP specific option, not
> gpio.
> 
> Andrew

In addition to gpio, not instead of it (the new driver uses the fdt
gpio helper stuff for card detect and write protect).

-- Ian