svn commit: r364989 - head/sys/dev/jedec_dimm

Ravi Pokala rpokala at freebsd.org
Tue Sep 1 05:27:31 UTC 2020


-----Original Message-----
From: <owner-src-committers at freebsd.org> on behalf of Eric van Gyzen <vangyzen at FreeBSD.org>
Date: 2020-08-31, Monday at 08:03
To: <src-committers at freebsd.org>, <svn-src-all at freebsd.org>, <svn-src-head at freebsd.org>
Subject: svn commit: r364989 - head/sys/dev/jedec_dimm

    Author: vangyzen
    Date: Mon Aug 31 15:03:23 2020
    New Revision: 364989
    URL: https://svnweb.freebsd.org/changeset/base/364989

    Log:
      jedec_dimm: fix array overrun

      Coverity detected the overrunning of sc->part_str.

      Submitted by:	bret_ketchum at dell.com
      Reported by:	Coverity
      MFC after:	2 weeks
      Sponsored by:	Dell EMC Isilon
      Differential Revision:	https://reviews.freebsd.org/D26145

Pointy-hat to: rpokala@

Bah, sorry, I completely missed this review. <facepalm>

Thanks for the fix, Bret. Thanks for reviewing and committing it, Eric.

-Ravi (rpokala@)

    Modified:
      head/sys/dev/jedec_dimm/jedec_dimm.c

    Modified: head/sys/dev/jedec_dimm/jedec_dimm.c
    ==============================================================================
    --- head/sys/dev/jedec_dimm/jedec_dimm.c	Mon Aug 31 14:47:23 2020	(r364988)
    +++ head/sys/dev/jedec_dimm/jedec_dimm.c	Mon Aug 31 15:03:23 2020	(r364989)
    @@ -795,7 +795,7 @@ jedec_dimm_field_to_str(struct jedec_dimm_softc *sc, c

     	/* If we're dealing with ASCII, convert trailing spaces to NULs. */
     	if (ascii) {
    -		for (i = dstsz; i > 0; i--) {
    +		for (i = dstsz - 1; i > 0; i--) {
     			if (dst[i] == ' ') {
     				dst[i] = 0;
     			} else if (dst[i] == 0) {




More information about the svn-src-all mailing list