svn commit: r366993 - head/sys/net

Alexander V. Chernikov melifaro at ipfw.ru
Sat Oct 24 13:38:21 UTC 2020


24.10.2020, 14:08, "Hans Petter Selasky" <hps at selasky.org>:
> On 2020-10-24 14:52, Alexey Dokuchaev wrote:
>>  On Sat, Oct 24, 2020 at 10:23:22AM +0000, Hans Petter Selasky wrote:
>>>  New Revision: 366993
>>>  URL: https://svnweb.freebsd.org/changeset/base/366993
>>>
>>>  Log:
>>>     Run code through "clang-format -style=file" with some additional fixes.
>>>     No functional change.
>>>
>>>  ...
>>>  @@ -99,8 +97,8 @@ infiniband_ipv4_multicast_map(uint32_t addr,
>>>
>>>    #ifdef INET6
>>>    static inline void
>>>  -infiniband_ipv6_multicast_map(const struct in6_addr *addr,
>>>  - const uint8_t *broadcast, uint8_t *buf)
>>>  +infiniband_ipv6_multicast_map(
>>>  + const struct in6_addr *addr, const uint8_t *broadcast, uint8_t *buf)
>>>    {
>>
>>  This is not how we format these in FreeBSD, please revert. It was correct
>>  before and no "fix" is need here.
Given we already have nice .clang-format, that does most of the job, maybe it's worth considering looking into tweaking it further to fix this part?
It would be nice if we could finally offload all formatting issues to the tool and focus on the actual code :-)
> Done.
>
> --HPS


More information about the svn-src-all mailing list