svn commit: r366936 - head/sys/net

[Konstantin Belousov]

On Fri, Oct 23, 2020 at 01:26:04PM +0200, Hans Petter Selasky wrote:
> On 2020-10-23 11:46, Konstantin Belousov wrote:
> > On Fri, Oct 23, 2020 at 10:04:12AM +0200, Hans Petter Selasky wrote:
> > > On 2020-10-22 19:54, Hans Petter Selasky wrote:
> > > > On 2020-10-22 18:48, Konstantin Belousov wrote:
> > > > > sys/systm.h already includes sys/param.h.  Also, sys/param.h already
> > > > > includes
> > > > > sys/types.h.
> > > > 
> > > > I'll have a look tomorrow at this. Thanks for pointing out.
> > > 
> > > It appears sys/systm.h needs sys/types.h included first:
> > Normally you do
> > #include <sys/param.h>
> > #include <sys/systm.h>
> > and I do not see why it would not work in this case.
> > 
> > > 
> > > > In file included from /usr/img/freebsd.svn/src/sys/sys/systm.h:44:
> > > > ./machine/atomic.h:230:1: error: unknown type name 'u_char'; did you mean 'char'?
> > > > ATOMIC_CMPSET(char);
> > > 
> > > --HPS
> 
> Hi,
> 
> The following works, but it doesn't make much difference.
It makes a difference because this is an idiomatic an intended use of
the headers.

> 
> Do we have a script or tool, which can do this?
I am not aware of.

> 
> --HPS
> 
> > Index: sys/net/if_infiniband.c
> > ===================================================================
> > --- sys/net/if_infiniband.c	(revision 366936)
> > +++ sys/net/if_infiniband.c	(working copy)
> > @@ -30,9 +30,8 @@
> >  __FBSDID("$FreeBSD$");
> >  #include <sys/param.h>
> > +#include <sys/systm.h>
> >  #include <sys/kernel.h>
> > -#include <sys/types.h>
> > -#include <sys/systm.h>
> >  #include <sys/eventhandler.h>
> >  #include <sys/socket.h>
> >  #include <sys/sysctl.h>