svn commit: r366372 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf
Kyle Evans
kevans at freebsd.org
Thu Oct 22 13:22:51 UTC 2020
On Sat, Oct 17, 2020 at 11:40 AM Warner Losh <imp at bsdimp.com> wrote:
>
>
>
> On Sat, Oct 17, 2020, 10:11 AM Alexander V. Chernikov <melifaro at ipfw.ru> wrote:
>>
>> 17.10.2020, 14:07, "Hans Petter Selasky" <hps at selasky.org>:
>>
>> On 2020-10-17 14:34, Alexander V. Chernikov wrote:
>>
>> 17.10.2020, 12:32, "Hans Petter Selasky" <hps at selasky.org>:
>>
>> On 2020-10-17 13:27, Alexander V. Chernikov wrote:
>>
>> 02.10.2020, 19:26, "Emmanuel Vadot" <manu at freebsd.org
>> <mailto:manu at freebsd.org>>:
>>
>> Author: manu
>> Date: Fri Oct 2 18:26:41 2020
>> New Revision: 366372
>> URL: https://svnweb.freebsd.org/changeset/base/366372
>>
>> Log:
>> linuxkpi: Add backlight support
>>
>> Add backlight function to linuxkpi.
>> Graphics drivers expose the backlight of the panel directly so
>> allow them
>> to use the backlight subsystem so
>> user can use backlight(8) to configure them.
>>
>> Reviewed by: hselasky
>> Relnotes: yes
>> Differential Revision: The FreeBSD Foundation
>>
>> Added:
>> head/sys/compat/linuxkpi/common/include/linux/backlight.h
>> (contents,
>> props changed)
>> Modified:
>> head/sys/compat/linuxkpi/common/include/linux/device.h
>> head/sys/compat/linuxkpi/common/src/linux_kmod.c
>> head/sys/compat/linuxkpi/common/src/linux_pci.c
>> head/sys/conf/kmod.mk
>>
>> It breaks the build for me with
>> /usr/home/melifaro/free/head/sys/compat/linuxkpi/common/src/linux_pci.c:70:10:
>> fatal error: 'backlight_if.h' file not found
>>
>>
>> How do you build? Doesn't break over here.
>>
>> GENERIC + COMPAT_LINUXKPI.
>>
>>
>>
>> Try adding:
>>
>> options backlight
>>
>> To the kernel config.
>>
>> Yep, thank you!
>> Maybe it's worth considering adding static assert with the message describing this dependency?
>
>
> Yes. It likely is worth doing something to highlight this issue.
>
> Warner
>
I think we just need to slap the two core backlight files with an ` |
compat_linux` so that they simply get pulled in if you specify
COMPAT_LINUX. config(8) handles this terribly, configng must have a
better provides/requires/implies/whatever functionality so we can
specify that compat_linux implies backlight and not do crud like this
where it becomes more complicated to see what any given option really
entails.
Thanks,
Kyle Evans
More information about the svn-src-all
mailing list