svn commit: r366207 - head/lib/libc/gen

Konstantin Belousov kostikbel at gmail.com
Thu Oct 1 15:45:00 UTC 2020


On Mon, Sep 28, 2020 at 07:01:38PM +0300, Konstantin Belousov wrote:
> On Mon, Sep 28, 2020 at 10:06:55AM -0500, Kyle Evans wrote:
> > I would be tempted to just revert the rest of the local modifications
> > (sans negative check, maybe) and widen it in the one spot that the
> > compiler complains about:
> > 
> > -                     if (strlcpy(buf, execpath, buflen_) >= buflen_)
> > +                     if (strlcpy(buf, execpath, buflen) >= (size_t)buflen)
> > 
> > I had expressed this in the review, but with no particular conviction.
> If this is the only place where the warning occurs, IMO it would be quite
> good to reduce the change.

So would you propose your change for review ?


More information about the svn-src-all mailing list