svn commit: r361209 - head/sys/netinet

Ian Lepore ian at freebsd.org
Mon May 18 20:48:19 UTC 2020


On Mon, 2020-05-18 at 22:43 +0200, Michael Tuexen wrote:
> > Sure.  You can certainly ignore user reports corresponding to bogus
> > flags, though, and encourage use of various flags.
> 
> I could, but decided to improve the situation for some people, but
> wasn't realising that I made it worse for others. Sorry about that.

I'm trying to figure out why your original commit was a problem.  I
understand why it was questioned, but once the answer came out, it's
clear that the code you originally committed does what it's supposed to
without any harmful side effects.  Sure, freebsd doesn't strictly need
it, but the code is shared among projects, so what's the harm in the
extra check that helps other projects sharing the code?  It's certainly
a lot less confusion and code clutter than any of the "remedies" that
have been discussed.

-- Ian



More information about the svn-src-all mailing list