svn commit: r361033 - in head/sys: amd64/amd64 arm64/arm64 dev/acpica i386/i386 x86/acpica

[Mark Johnston]

Author: markj
Date: Thu May 14 16:07:27 2020
New Revision: 361033
URL: https://svnweb.freebsd.org/changeset/base/361033

Log:
  Call acpi_pxm_set_proximity_info() slightly earlier on x86.
  
  This function is responsible for setting pc_domain in each pcpu
  structure.  Call it from the main function that starts APs, rather than
  a separate SYSINIT.  This makes it easier to close the window where
  UMA's per-CPU slab allocator may be called while pc_domain is
  uninitialized.  In particular, the allocator uses pc_domain to allocate
  domain-local pages, so allocations before this point end up using domain
  0 for everything.
  
  Reviewed by:	kib
  MFC after:	1 week
  Sponsored by:	The FreeBSD Foundation
  Differential Revision:	https://reviews.freebsd.org/D24757

Modified:
  head/sys/amd64/amd64/mp_machdep.c
  head/sys/arm64/arm64/mp_machdep.c
  head/sys/dev/acpica/acpi_pxm.c
  head/sys/dev/acpica/acpivar.h
  head/sys/i386/i386/mp_machdep.c
  head/sys/x86/acpica/srat.c

Modified: head/sys/amd64/amd64/mp_machdep.c
==============================================================================
--- head/sys/amd64/amd64/mp_machdep.c	Thu May 14 16:06:54 2020	(r361032)
+++ head/sys/amd64/amd64/mp_machdep.c	Thu May 14 16:07:27 2020	(r361033)
@@ -264,8 +264,9 @@ cpu_mp_start(void)
 	init_ops.start_all_aps();
 
 	set_interrupt_apic_ids();
-}
 
+	acpi_pxm_set_cpu_locality();
+}
 
 /*
  * AP CPU's call this to initialize themselves.

Modified: head/sys/arm64/arm64/mp_machdep.c
==============================================================================
--- head/sys/arm64/arm64/mp_machdep.c	Thu May 14 16:06:54 2020	(r361032)
+++ head/sys/arm64/arm64/mp_machdep.c	Thu May 14 16:07:27 2020	(r361033)
@@ -535,9 +535,7 @@ cpu_init_acpi(void)
 	acpi_unmap_table(madt);
 
 #if MAXMEMDOM > 1
-	/* set proximity info */
 	acpi_pxm_set_cpu_locality();
-	acpi_pxm_free();
 #endif
 }
 #endif

Modified: head/sys/dev/acpica/acpi_pxm.c
==============================================================================
--- head/sys/dev/acpica/acpi_pxm.c	Thu May 14 16:06:54 2020	(r361032)
+++ head/sys/dev/acpica/acpi_pxm.c	Thu May 14 16:07:27 2020	(r361033)
@@ -628,7 +628,8 @@ srat_walk_table(acpi_subtable_handler *handler, void *
 }
 
 /*
- * Setup per-CPU domain IDs from information saved in 'cpus'.
+ * Set up per-CPU domain IDs from information saved in 'cpus' and tear down data
+ * structures allocated by acpi_pxm_init().
  */
 void
 acpi_pxm_set_cpu_locality(void)
@@ -651,6 +652,10 @@ acpi_pxm_set_cpu_locality(void)
 			printf("SRAT: CPU %u has memory domain %d\n", i,
 			    pc->pc_domain);
 	}
+	/* XXXMJ the page is leaked. */
+	pmap_unmapbios((vm_offset_t)cpus, sizeof(*cpus) * max_cpus);
+	srat_physaddr = 0;
+	cpus = NULL;
 }
 
 int
@@ -662,20 +667,6 @@ acpi_pxm_get_cpu_locality(int apic_id)
 	if (cpu == NULL)
 		panic("SRAT: CPU with ID %u is not known", apic_id);
 	return (cpu->domain);
-}
-
-/*
- * Free data structures allocated during acpi_pxm_init.
- */
-void
-acpi_pxm_free(void)
-{
-
-	if (srat_physaddr == 0)
-		return;
-	pmap_unmapbios((vm_offset_t)cpus, sizeof(*cpus) * max_cpus);
-	srat_physaddr = 0;
-	cpus = NULL;
 }
 
 /*

Modified: head/sys/dev/acpica/acpivar.h
==============================================================================
--- head/sys/dev/acpica/acpivar.h	Thu May 14 16:06:54 2020	(r361032)
+++ head/sys/dev/acpica/acpivar.h	Thu May 14 16:07:27 2020	(r361033)
@@ -540,7 +540,6 @@ void		acpi_pxm_parse_tables(void);
 void		acpi_pxm_set_mem_locality(void);
 void		acpi_pxm_set_cpu_locality(void);
 int		acpi_pxm_get_cpu_locality(int apic_id);
-void		acpi_pxm_free(void);
 
 /*
  * Map a PXM to a VM domain.

Modified: head/sys/i386/i386/mp_machdep.c
==============================================================================
--- head/sys/i386/i386/mp_machdep.c	Thu May 14 16:06:54 2020	(r361032)
+++ head/sys/i386/i386/mp_machdep.c	Thu May 14 16:07:27 2020	(r361033)
@@ -198,6 +198,8 @@ cpu_mp_start(void)
 	start_all_aps();
 
 	set_interrupt_apic_ids();
+
+	acpi_pxm_set_cpu_locality();
 }
 
 /*

Modified: head/sys/x86/acpica/srat.c
==============================================================================
--- head/sys/x86/acpica/srat.c	Thu May 14 16:06:54 2020	(r361032)
+++ head/sys/x86/acpica/srat.c	Thu May 14 16:07:27 2020	(r361033)
@@ -56,13 +56,4 @@ parse_acpi_tables(void *dummy)
 SYSINIT(parse_acpi_tables, SI_SUB_VM - 1, SI_ORDER_FIRST, parse_acpi_tables,
     NULL);
 
-static void
-srat_set_cpus(void *dummy)
-{
-
-	acpi_pxm_set_cpu_locality();
-	acpi_pxm_free();
-}
-SYSINIT(srat_set_cpus, SI_SUB_CPU, SI_ORDER_ANY, srat_set_cpus, NULL);
-
 #endif /* MAXMEMDOM > 1 */