svn commit: r360863 - stable/12/sys/cam/ctl

[Alexander Motin]

Author: mav
Date: Sun May 10 02:13:38 2020
New Revision: 360863
URL: https://svnweb.freebsd.org/changeset/base/360863

Log:
  MFC r360610: Add session locking in cfiscsi_ioctl_handoff().
  
  While there, remove ifdef around cs_target check in cfiscsi_ioctl_list().
  I am not sure why this ifdef was added, but without this check code will
  crash below on NULL dereference.

Modified:
  stable/12/sys/cam/ctl/ctl_frontend_iscsi.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/cam/ctl/ctl_frontend_iscsi.c
==============================================================================
--- stable/12/sys/cam/ctl/ctl_frontend_iscsi.c	Sun May 10 00:34:09 2020	(r360862)
+++ stable/12/sys/cam/ctl/ctl_frontend_iscsi.c	Sun May 10 02:13:38 2020	(r360863)
@@ -1582,8 +1582,10 @@ cfiscsi_ioctl_handoff(struct ctl_iscsi *ci)
 	mtx_lock(&softc->lock);
 	if (ct->ct_online == 0) {
 		mtx_unlock(&softc->lock);
+		CFISCSI_SESSION_LOCK(cs);
 		cs->cs_handoff_in_progress = false;
 		cfiscsi_session_terminate(cs);
+		CFISCSI_SESSION_UNLOCK(cs);
 		cfiscsi_target_release(ct);
 		ci->status = CTL_ISCSI_ERROR;
 		snprintf(ci->error_str, sizeof(ci->error_str),
@@ -1629,8 +1631,10 @@ restart:
 #endif
 		error = icl_conn_handoff(cs->cs_conn, cihp->socket);
 		if (error != 0) {
+			CFISCSI_SESSION_LOCK(cs);
 			cs->cs_handoff_in_progress = false;
 			cfiscsi_session_terminate(cs);
+			CFISCSI_SESSION_UNLOCK(cs);
 			ci->status = CTL_ISCSI_ERROR;
 			snprintf(ci->error_str, sizeof(ci->error_str),
 			    "%s: icl_conn_handoff failed with error %d",
@@ -1692,10 +1696,8 @@ cfiscsi_ioctl_list(struct ctl_iscsi *ci)
 	sbuf_printf(sb, "<ctlislist>\n");
 	mtx_lock(&softc->lock);
 	TAILQ_FOREACH(cs, &softc->sessions, cs_next) {
-#ifdef ICL_KERNEL_PROXY
 		if (cs->cs_target == NULL)
 			continue;
-#endif
 		error = sbuf_printf(sb, "<connection id=\"%d\">"
 		    "<initiator>%s</initiator>"
 		    "<initiator_addr>%s</initiator_addr>"