svn commit: r358518 - head/usr.bin/elfctl

[Ed Maste]

On Sun, 1 Mar 2020 at 23:22, Kyle Evans <kevans at freebsd.org> wrote:
>
> Author: kevans
> Date: Mon Mar  2 04:22:38 2020
> New Revision: 358518
> URL: https://svnweb.freebsd.org/changeset/base/358518
>
> Log:
>   elfctl: initialize features
>
>   GCC points out a couple levels down in convert_to_features that this may be
>   used uninitialized. Indeed, this is true- initialize it to NULL so that we
>   at least deref a null pointer.

Note that features is only used in the case that editfeatures = 1, so
I believe this is a false positive from GCC.

But, thank you for fixing the warning / build. This code code
definitely use some style(9) and tidying; I'll try to get to that
shortly.