svn commit: r362217 - head/stand/common
Ian Lepore
ian at freebsd.org
Wed Jun 17 02:33:15 UTC 2020
On Tue, 2020-06-16 at 19:34 +0200, Kristof Provost wrote:
> On 16 Jun 2020, at 19:11, Ed Maste wrote:
> > On Tue, 16 Jun 2020 at 13:01, Ian Lepore <ian at freebsd.org> wrote:
> > >
> > > As much as I prefer doing it this way, style(9) doesn't allow for
> > > variable declarations inside a for() statement (or even inside a
> > > local
> > > block, which is just too 1980s for me, but it is still our standard).
> >
> > Perhaps it's time to update style(9) to at least permit these uses, as
> > we've done with the blank line at the beginning of functions with no
> > local variables, and with braces around single-line bodies.
>
> We have 431 instances of `for (int i` in sys alone. It’s not so much a
> question of allowing it as acknowledging reality at this point.
>
> Best regards,
> Kristof
Hmm, so we do. If you weed out sys/contrib, and device drivers
contributed by vendors, the number is a lot smaller, but still big
enough that we should just change the rules I think.
-- Ian
More information about the svn-src-all
mailing list