svn commit: r363170 - in head: contrib/byacc contrib/byacc/package contrib/byacc/package/debian contrib/byacc/package/pkgsrc contrib/byacc/test contrib/byacc/test/btyacc contrib/byacc/test/yacc usr...

[Li-Wen Hsu]

On Wed, Jul 15, 2020 at 6:14 AM Li-Wen Hsu <lwhsu at freebsd.org> wrote:
>
> On Tue, Jul 14, 2020 at 9:54 AM Jung-uk Kim <jkim at freebsd.org> wrote:
> >
> > Author: jkim
> > Date: Tue Jul 14 01:54:24 2020
> > New Revision: 363170
> > URL: https://svnweb.freebsd.org/changeset/base/363170
> >
> > Log:
> >   MFV:  r362513
> >
> >   Update byacc to 20200330.
>
> Hello Jung-uk,
>
> There are some things I haven't figured out, but currently there is
> one yacc test case in our CI is failing.
>
> Please check the output of usr.bin.yacc.yacc_tests.main at
> https://ci.freebsd.org/job/FreeBSD-head-amd64-test/15843/testReport/junit/usr.bin.yacc/yacc_tests/main/
>
> The yacc processed result of /usr/tests/usr.bin/yacc/calc.y is
> different than the reference,
> /usr/tests/usr.bin/yacc/yacc/calc.tab.c
>
> And checking the files under contrib/byacc/ , there are
> (1) ./test/calc.tab.c
> (2) ./test/btyacc/calc.tab.c
> (3) ./test/yacc/calc.tab.c
>
> (3) is what we want, and that was the source of
> /usr/tests/usr.bin/yacc/yacc/calc.tab.c before this import. It was
> updated in the new byacc release and matches the behavior of new yacc.
> However, currently we install (1) as /usr/tests/usr.bin/yacc/calc.y ,

Sorry, I mean currently we install (1) as
/usr/tests/usr.bin/yacc/yacc/calc.tab.c

> the content looks generated by a very old yacc
>
> The thing I still don't know is why the source of calc.tab.c is
> changed as there is no related change in usr.bin/yacc/tests/Makefile .
> Surprisingly, removing (1) can restore the old behavior of using (3)
> as the source. I haven't checked why that file appears in the upstream
> distfile but it did not exist in our old version of byacc, 20170201.
>
> I'm not sure what's the best way to fix this. The fastest way is just
> removing contrib/byacc/test/calc.tab.c , and the following task is
> checking with upstream for the intention of adding that file.  We may
> also want to fix the Makefile or .mk files to make the source of
> /usr/tests/usr.bin/yacc/yacc/calc.tab.c not affected by the file with
> the same name under different directories.
>
> BTW, there are some entries need to be added to the ObsoleteFiles.inc, like
> /usr/tests/usr.bin/yacc/err_inherit1.y which is
>
> Please help check this test issue of the new yacc.
>
> Thanks,
> Li-Wen