svn commit: r363172 - head/contrib/bc/src

[Stefan Eßer]

Am 14.07.20 um 19:31 schrieb Brooks Davis:
> On Tue, Jul 14, 2020 at 05:02:18AM +0000, Adrian Chadd wrote:
>> Author: adrian
>> Date: Tue Jul 14 05:02:18 2020
>> New Revision: 363172
>> URL: https://svnweb.freebsd.org/changeset/base/363172
>>
>> Log:
>>   [bc] Fix a "maybe uninitialized" compiler warning under mips-gcc-6.3.0.
>>   
>>   I guess this didn't like the case statements.. ? But this does quieten
>>   the compiler error.
> 
> IMO it would be better to disable this warning for this (old) compiler
> on this file rather than making a change here (in general we should be
> removing these sorts of changes).  That being said, we need to write
> down some guidance on this so we have a clear set of principles and we
> can figure out how we decided which compilers are on which side of the
> line.

I fully agree and have notified the "upstream". He may want to apply
the change, but I do not expect him to tag a new release for this minor
change.

Since this is contributed software, I'd really appreciate, if a solution
was only applied to the local build tree of the person affected by this
local problem - a generally applicable solution can then be discussed
and applied, if found to be necessary.

Regards, STefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20200714/2e91cad0/attachment.sig>