svn commit: r357291 - in head/sys/dev: bwi bwn ipw iwi iwm iwn malo mwl ral rtwn/pci wi wpi wtap

[Gleb Smirnoff]

On Thu, Jan 30, 2020 at 10:51:23AM -1000, Jeff Roberson wrote:
J> On Thu, 30 Jan 2020, Gleb Smirnoff wrote:
J> 
J> > On Thu, Jan 30, 2020 at 10:28:01AM +0000, Hans Petter Selasky wrote:
J> > H> Author: hselasky
J> > H> Date: Thu Jan 30 10:28:01 2020
J> > H> New Revision: 357291
J> > H> URL: https://svnweb.freebsd.org/changeset/base/357291
J> > H>
J> > H> Log:
J> > H>   Widen EPOCH(9) usage in PCI WLAN drivers.
J> > H>
J> > H>   Make sure all occurrences of ieee80211_input_xxx() in sys/dev are
J> > H>   covered by a network epoch section. Do not depend on the interrupt
J> > H>   handler nor any taskqueues being in a network epoch section.
J> > H>
J> > H>   This patch should unbreak the PCI WLAN drivers after r357004.
J> > H>
J> > H>   Pointy hat:	glebius@
J> > H>   Sponsored by:	Mellanox Technologies
J> >
J> > Hey, I have reviewed all of them.
J> >
J> > The following drivers were not broken, and your change does 100%
J> > recursive epoch_enter:
J> >
J> > bwi, ipw, iwi, iwm, iwn, ral, rtwn, wi, wpi
J> >
J> > The following drivers use taskq and would be fixed by D23408:
J> >
J> > bwn, malo, mwl, wtap
J> >
J> > P.S. A funny note about wtap. You modified even a function that
J> > is a dead code - wtap_rx_deliver(). Gives some clue on quality
J> > of your sweep over all drivers.
J> 
J> I would strongly suggest that we not make more changes to this area 
J> without a discussion on a review to make sure we're all in agreement. 
J> There are some fine technical details which would benefit from multiple 
J> eyes and failing to act together is creating more conflict than is 
J> necessary.  I volunteer to be on the reviews as an impartial third party.

Don't worry, I'm not going to participate in the commit war Hans started.

-- 
Gleb Smirnoff