svn commit: r357246 - head/tests/sys/sys

Conrad Meyer cem at freebsd.org
Wed Jan 29 22:38:47 UTC 2020


Hi Li-Wen,

Thanks for the report.  I went ahead and reverted it in r357273.

Best,
Conrad

On Wed, Jan 29, 2020 at 8:47 AM Li-Wen Hsu <lwhsu at freebsd.org> wrote:
>
> On Wed, Jan 29, 2020 at 1:25 PM Conrad Meyer <cem at freebsd.org> wrote:
> >
> > Author: cem
> > Date: Wed Jan 29 05:25:20 2020
> > New Revision: 357246
> > URL: https://svnweb.freebsd.org/changeset/base/357246
> >
> > Log:
> >   qmath(3) test: Replace overcomplicated abomination with arc4random(3)
> >
> >   The horrific GENRAND construction bent over backwards to construct 64-bit
> >   signed integers from the 31-bit output of random(3) for about 20 numbers per
> >   test.  Reproducibility wasn't a goal: random(3) was seeded with
> >   srandomdev(3).  Speed is not a factor for generating 20 integers with
> >   arc4random(3).  Range is not a factor: all uses did not bound the range
> >   beyond that of the full [INT64_MIN, INT64_MAX].  Just use arc4random(3).
> >
> >   Reported by:  Coverity
> >   CIDs:         1404809, 1404817, 1404838, 1404840 and about 6x other
> >                 identical reports of dubious code relating to the
> >                 construction
> >
> > Modified:
> >   head/tests/sys/sys/qmath_test.c
>
> These two test cases are starting failing since this commit:
> https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14110/testReport/sys.sys/qmath_test/qsubi_s64q/
> https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14110/testReport/sys.sys/qmath_test/qsubq_s64q/
>
> Can you help check them? Thanks!
>
> Li-Wen


More information about the svn-src-all mailing list