svn commit: r356901 - head/sys/dev/mps

Conrad Meyer cem at FreeBSD.org
Sun Jan 19 22:52:37 UTC 2020


Author: cem
Date: Sun Jan 19 22:52:36 2020
New Revision: 356901
URL: https://svnweb.freebsd.org/changeset/base/356901

Log:
  mps(4): add missing cam(4) dependency
  
  On a MINIMAL kernel, mps.ko wouldn't load because it uses the xpt_hold_boot
  symbol from CAM, but didn't have a dependency on cam(4).
  
  (CEM: Some context: when linking loaded modules, the kernel dynamic linker
  only looks for definitions in explictly marked dependency modules.  Also,
  the identical mpr(4) driver uses the same CAM function, but already had the
  correct MODULE_DEPEND(), so no similar change is needed there.)
  
  Submitted by:	Greg V <greg AT unrelenting.technology>
  Reviewed by:	imp, myself
  Differential Revision:	https://reviews.freebsd.org/D23272

Modified:
  head/sys/dev/mps/mps_pci.c

Modified: head/sys/dev/mps/mps_pci.c
==============================================================================
--- head/sys/dev/mps/mps_pci.c	Sun Jan 19 22:29:22 2020	(r356900)
+++ head/sys/dev/mps/mps_pci.c	Sun Jan 19 22:52:36 2020	(r356901)
@@ -145,6 +145,7 @@ struct mps_ident {
 
 static devclass_t	mps_devclass;
 DRIVER_MODULE(mps, pci, mps_pci_driver, mps_devclass, 0, 0);
+MODULE_DEPEND(mps, cam, 1, 1, 1);
 MODULE_PNP_INFO("U16:vendor;U16:device;U16:subvendor;U16:subdevice", pci, mps,
     mps_identifiers, nitems(mps_identifiers) - 1);
 static struct mps_ident *


More information about the svn-src-all mailing list