svn commit: r356852 - head/sys/net80211
Conrad Meyer
cem at FreeBSD.org
Fri Jan 17 22:04:12 UTC 2020
Author: cem
Date: Fri Jan 17 22:04:11 2020
New Revision: 356852
URL: https://svnweb.freebsd.org/changeset/base/356852
Log:
net80211: Move rate printing in amrr_node_stats() to a separate method
This makes amrr_node_stats() cleaner and allows the rate printing to be
reusable.
Submitted by: Neel Chauhan <neel at neelc.org>
Reviewed by: adrian
Differential Revision: https://reviews.freebsd.org/D22318
Modified:
head/sys/net80211/ieee80211_amrr.c
Modified: head/sys/net80211/ieee80211_amrr.c
==============================================================================
--- head/sys/net80211/ieee80211_amrr.c Fri Jan 17 22:02:35 2020 (r356851)
+++ head/sys/net80211/ieee80211_amrr.c Fri Jan 17 22:04:11 2020 (r356852)
@@ -477,18 +477,12 @@ amrr_sysctlattach(struct ieee80211vap *vap,
}
static void
-amrr_node_stats(struct ieee80211_node *ni, struct sbuf *s)
+amrr_print_node_rate(struct ieee80211_amrr_node *amn,
+ struct ieee80211_node *ni, struct sbuf *s)
{
int rate;
- struct ieee80211_amrr_node *amn = ni->ni_rctls;
struct ieee80211_rateset *rs;
- /* XXX TODO: check locking? */
-
- if (!amn)
- return;
-
- /* XXX TODO: this should be a method */
if (amrr_node_is_11n(ni)) {
rs = (struct ieee80211_rateset *) &ni->ni_htrates;
rate = rs->rs_rates[amn->amn_rix] & IEEE80211_RATE_VAL;
@@ -498,7 +492,19 @@ amrr_node_stats(struct ieee80211_node *ni, struct sbuf
rate = rs->rs_rates[amn->amn_rix] & IEEE80211_RATE_VAL;
sbuf_printf(s, "rate: %d Mbit\n", rate / 2);
}
+}
+static void
+amrr_node_stats(struct ieee80211_node *ni, struct sbuf *s)
+{
+ struct ieee80211_amrr_node *amn = ni->ni_rctls;
+
+ /* XXX TODO: check locking? */
+
+ if (!amn)
+ return;
+
+ amrr_print_node_rate(amn, ni, s);
sbuf_printf(s, "ticks: %d\n", amn->amn_ticks);
sbuf_printf(s, "txcnt: %u\n", amn->amn_txcnt);
sbuf_printf(s, "success: %u\n", amn->amn_success);
More information about the svn-src-all
mailing list