svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

John Baldwin jhb at FreeBSD.org
Thu Jan 16 17:27:26 UTC 2020


On 1/15/20 2:38 PM, Gleb Smirnoff wrote:
> On Wed, Jan 15, 2020 at 09:44:53AM -1000, Jeff Roberson wrote:
> J> On Wed, 15 Jan 2020, Gleb Smirnoff wrote:
> J> 
> J> > Author: glebius
> J> > Date: Wed Jan 15 06:05:20 2020
> J> > New Revision: 356755
> J> > URL: https://svnweb.freebsd.org/changeset/base/356755
> J> >
> J> > Log:
> J> >  Introduce NET_EPOCH_CALL() macro and use it everywhere where we free
> J> >  data based on the network epoch.   The macro reverses the argument
> J> >  order of epoch_call(9) - first function, then its argument. NFC
> J> 
> J> Is there some practical impact of changing the argument order or does it 
> J> just seem more natural to you?
> 
> It is just more natural. I'm suggesting to change prototype of epoch_call()
> to the same order as well.

+1 for fn, arg.

-- 
John Baldwin


More information about the svn-src-all mailing list