svn commit: r356566 - stable/11/contrib/smbfs/lib/smb

[Eugene Grosbein]

10.01.2020 2:58, Baptiste Daroussin wrote:

> Author: bapt
> Date: Thu Jan  9 19:58:05 2020
> New Revision: 356566
> URL: https://svnweb.freebsd.org/changeset/base/356566
> 
> Log:
>   MFC r356317 (by arrowd):
>   
>   mount_smbfs: Issue a warning when .nsmbrc section name contains lowercase characters.
>   
>   PR:  231656
>   Approved by: bapt
>   Differential Revision: https://reviews.freebsd.org/D22289
> 
> Modified:
>   stable/11/contrib/smbfs/lib/smb/rcfile.c
> Directory Properties:
>   stable/11/   (props changed)
> 
> Modified: stable/11/contrib/smbfs/lib/smb/rcfile.c
> ==============================================================================
> --- stable/11/contrib/smbfs/lib/smb/rcfile.c	Thu Jan  9 19:56:25 2020	(r356565)
> +++ stable/11/contrib/smbfs/lib/smb/rcfile.c	Thu Jan  9 19:58:05 2020	(r356566)
> @@ -156,11 +156,19 @@ static struct rcsection *
>  rc_addsect(struct rcfile *rcp, const char *sectname)
>  {
>  	struct rcsection *p;
> +	const char* sectletter = sectname;
>  
>  	p = rc_findsect(rcp, sectname);
>  	if (p) return p;
>  	p = malloc(sizeof(*p));
>  	if (!p) return NULL;
> +	for(sectletter = sectname; *sectletter; sectletter++) {
> +		if (islower(*sectletter)) {
> +			if (strcmp(sectname, "default"))
> +				dprintf(STDERR_FILENO, "warning: section name [%s] contains lower-case letters\n", sectname);
> +			break;
> +		}
> +	}
>  	p->rs_name = strdup(sectname);
>  	SLIST_INIT(&p->rs_keys);
>  	SLIST_INSERT_HEAD(&rcp->rf_sect, p, rs_next);

This commit broke source upgrade path from 10.4-STABLE to stable/11:

rcfile.c:168:5: error: implicit declaration of function 'dprintf' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                                dprintf(STDERR_FILENO, "warning: section name [%s] contains lower-case letters\n", sectname);
                                ^
1 error generated.