svn commit: r356551 - head/usr.sbin/arp

[Eugene Grosbein]

Author: eugen
Date: Thu Jan  9 11:58:26 2020
New Revision: 356551
URL: https://svnweb.freebsd.org/changeset/base/356551

Log:
  arp(8): avoid segfaulting due to out-of-bounds memory access
  
  Fix obvious mistake that sometimes results in reading memory
  past end of an array.
  
  PR:		240825
  MFC after:	1 week

Modified:
  head/usr.sbin/arp/arp.c

Modified: head/usr.sbin/arp/arp.c
==============================================================================
--- head/usr.sbin/arp/arp.c	Thu Jan  9 10:26:36 2020	(r356550)
+++ head/usr.sbin/arp/arp.c	Thu Jan  9 11:58:26 2020	(r356551)
@@ -627,8 +627,7 @@ print_entry(struct sockaddr_dl *sdl,
 	} else
 		xo_emit("{d:/(incomplete)}{en:incomplete/true}");
 
-	for (p = ifnameindex; p && ifnameindex->if_index &&
-	    ifnameindex->if_name; p++) {
+	for (p = ifnameindex; p && p->if_index && p->if_name; p++) {
 		if (p->if_index == sdl->sdl_index) {
 			xo_emit(" on {:interface/%s}", p->if_name);
 			break;