svn commit: r358317 - head/sys/kern

Ravi Pokala rpokala at freebsd.org
Wed Feb 26 23:12:37 UTC 2020


-----Original Message-----
From: Gleb Smirnoff <glebius at freebsd.org>
Date: 2020-02-26, Wednesday at 13:55
To: Ravi Pokala <rpokala at freebsd.org>
Cc: <src-committers at freebsd.org>, <svn-src-all at freebsd.org>, <svn-src-head at freebsd.org>
Subject: Re: svn commit: r358317 - head/sys/kern

    On Tue, Feb 25, 2020 at 12:02:29PM -0800, Ravi Pokala wrote:
    R>       When sendfile_swapin() sweeps through pages in search for a bogus page
    R>       skip first and last pages.  This is a micro optimisation.
    R> 
    R> Yes, but *why* skip the first and last pages?
    
    We may have inserted bogus pages in the middle of a request. We never substitute
    first or last.
    
    -- 
    Gleb Smirnoff

Oh god, "bogus_page" -- Panasas had to jump through a bunch of hoops involving bogus_page and our RAIDing-across-sectors GEOM class years ago. <shudder>

-Ravi (rpokala@)





More information about the svn-src-all mailing list