svn commit: r358167 - head/sys/netinet6

Bjoern A. Zeeb bz at FreeBSD.org
Mon Feb 24 17:19:48 UTC 2020


On 24 Feb 2020, at 14:21, Hans Petter Selasky wrote:

Hi Hans,

> On 2020-02-20 11:56, Bjoern A. Zeeb wrote:
>
>> +
>> +		unfragpartlen = optlen + sizeof(struct ip6_hdr);
>> +
>
>
> Hi Bjoren,
>
> This change introduces a slight regression when a host replies to IPv6 
> ping fragmented packets. The problem is the "unfragpartlen" must also 
> be set in the else case of "if (opt)", else the payload offset 
> computation for IPv6 fragments goes wrong by the size of the IPv6 
> header!
>
> After r358167:
>
>
>> ping6 -s 3000 fe80::ee0d:9aff:fed4:2c8c%mce2
>> PING6(3048=40+8+3000 bytes) fe80::ee0d:9aff:fed4:2c94%mce2 --> 
>> fe80::ee0d:9aff:fed4:2c8c%mce2
>> ^C
>> --- fe80::ee0d:9aff:fed4:2c8c%mce2 ping6 statistics ---
>> 2 packets transmitted, 0 packets received, 100.0% packet loss
>
>
> With the patch mentioned in the end of this e-mail:

are you sure that this is the problem?  Or does 
https://reviews.freebsd.org/D23760 solve the actual problem?

/bz


More information about the svn-src-all mailing list