svn commit: r358091 - head/usr.sbin/certctl

Kyle Evans kevans at FreeBSD.org
Wed Feb 19 02:34:57 UTC 2020


Author: kevans
Date: Wed Feb 19 02:34:56 2020
New Revision: 358091
URL: https://svnweb.freebsd.org/changeset/base/358091

Log:
  certctl(8): switch to install(1) to fix DESTDIR support
  
  "Oops" - ln(1) is fine and dandy, but when you're using DESTDIR...it's not-
  the path will almost certainly be invalid once the root you've just
  installed to is relocated, perhaps to /.
  
  Switch to install(1) using `-l rs` to calculate the relative symlink between
  the two, which should work just fine in all cases.
  
  MFC after:	1 week

Modified:
  head/usr.sbin/certctl/certctl.sh

Modified: head/usr.sbin/certctl/certctl.sh
==============================================================================
--- head/usr.sbin/certctl/certctl.sh	Wed Feb 19 01:51:44 2020	(r358090)
+++ head/usr.sbin/certctl/certctl.sh	Wed Feb 19 02:34:56 2020	(r358091)
@@ -69,7 +69,7 @@ create_trusted_link()
 		return 1
 	fi
 	[ $VERBOSE -gt 0 ] && echo "Adding $hash.0 to trust store"
-	[ $NOOP -eq 0 ] && ln -fs $(realpath "$1") "$CERTDESTDIR/$hash.0"
+	[ $NOOP -eq 0 ] && install -lrs $(realpath "$1") "$CERTDESTDIR/$hash.0"
 }
 
 create_blacklisted()
@@ -88,7 +88,7 @@ create_blacklisted()
 		return
 	fi
 	[ $VERBOSE -gt 0 ] && echo "Adding $filename to blacklist"
-	[ $NOOP -eq 0 ] && ln -fs "$srcfile" "$BLACKLISTDESTDIR/$filename"
+	[ $NOOP -eq 0 ] && install -lrs "$srcfile" "$BLACKLISTDESTDIR/$filename"
 }
 
 do_scan()


More information about the svn-src-all mailing list