svn commit: r365917 - in releng/12.2: cddl/contrib/opensolaris/cmd/zfs cddl/contrib/opensolaris/cmd/zpool sys/cddl/compat/opensolaris/kern sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opensolar...

[Stefan Esser]

Am 16.12.20 um 21:30 schrieb Alan Somers:
> On Sat, Sep 19, 2020 at 2:47 PM Allan Jude <allanjude at freebsd.org 
> <mailto:allanjude at freebsd.org>> wrote:
> 
>     Author: allanjude
>     Date: Sat Sep 19 20:46:56 2020
>     New Revision: 365917
>     URL: https://svnweb.freebsd.org/changeset/base/365917
>     <https://svnweb.freebsd.org/changeset/base/365917>
> 
>     Log:
>        MFS r365689,r365808,r365860
> 
>        MFOpenZFS: Introduce read/write kstats per dataset
> 
>        The following patch introduces a few statistics on reads and writes
>        grouped by dataset. These statistics are implemented as kstats
>        (backed by aggregate sums for performance) and can be retrieved by
>        using the dataset objset ID number. The motivation for this change is
>        to provide some preliminary analytics on dataset usage/performance.
> 
>        Reviewed-by: Richard Elling <Richard.Elling at RichardElling.com>
>        Reviewed-by: Brian Behlendorf <behlendorf1 at llnl.gov
>     <mailto:behlendorf1 at llnl.gov>>
>        Reviewed by: Matthew Ahrens <mahrens at delphix.com
>     <mailto:mahrens at delphix.com>>
>        Signed-off-by: Serapheim Dimitropoulos <serapheim at delphix.com
>     <mailto:serapheim at delphix.com>>
> 
>        openzfs/zfs at a448a2557ec4938ed6944c7766fe0b8e6e5f6456
> 
>        Also contains parts of:
>        MFOpenZFS: Connect dataset_kstats for FreeBSD
> 
>        Example output:
>        kstat.zfs.mypool.dataset.objset-0x10b.nread: 150528
>        kstat.zfs.mypool.dataset.objset-0x10b.reads: 48
>        kstat.zfs.mypool.dataset.objset-0x10b.nwritten: 134217728
>        kstat.zfs.mypool.dataset.objset-0x10b.writes: 1024
>        kstat.zfs.mypool.dataset.objset-0x10b.dataset_name:
>     mypool/datasetname
> 
>        Reviewed-by: Ryan Moeller <ryan at iXsystems.com>
>        Reviewed by: Sean Eric Fagan <sef at ixsystems.com
>     <mailto:sef at ixsystems.com>>
>        Reviewed-by: Serapheim Dimitropoulos <serapheim at delphix.com
>     <mailto:serapheim at delphix.com>>
>        Reviewed-by: Brian Behlendorf <behlendorf1 at llnl.gov
>     <mailto:behlendorf1 at llnl.gov>>
>        Signed-off-by: Allan Jude <allan at klarasystems.com
>     <mailto:allan at klarasystems.com>>
> 
>        openzfs/zfs at 4547fc4e071ceb1818b3a46c3035b923e06e5390
> 
>        Approved by:  re (gjb)
>        Relnotes:     yes
>        Sponsored by: Klara Inc.
> 
> 
> This sounds quite useful!  I've often wished that I could see 
> per-dataset traffic statistics.  Are there any user-friendly frontends 
> to this?  Like zfs-stats, or an updated zpool iostat?

I have updated zfs-stats for OpenZFS a few months ago and I'd be willing
to add printing these new values to the port.

The maintainer of the upstream version had little interest to accept my
patches into his repository (after sending several request) and thus I
have added a large patch to the port.

If further changes are applied, I might fork the upstream repository
and base the zfs-stats port on that fork (but I did not want to grab it
without the current maintainer agreeing ...)

Regards, STefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20201217/c73aae4b/attachment.sig>