svn commit: r364818 - head/usr.sbin/efibootmgr

Toomas Soome tsoome at FreeBSD.org
Wed Aug 26 14:02:39 UTC 2020


Author: tsoome
Date: Wed Aug 26 14:02:38 2020
New Revision: 364818
URL: https://svnweb.freebsd.org/changeset/base/364818

Log:
  efibootmgr: wrong check for opts.order
  
  opts.order && !(opts.order) does not really make sense.
  
  Reported by:	swildner

Modified:
  head/usr.sbin/efibootmgr/efibootmgr.c

Modified: head/usr.sbin/efibootmgr/efibootmgr.c
==============================================================================
--- head/usr.sbin/efibootmgr/efibootmgr.c	Wed Aug 26 13:13:57 2020	(r364817)
+++ head/usr.sbin/efibootmgr/efibootmgr.c	Wed Aug 26 14:02:38 2020	(r364818)
@@ -295,7 +295,7 @@ parse_args(int argc, char *argv[])
 		return;
 	}
 
-	if (opts.order && !(opts.order))
+	if (opts.order != NULL && *opts.order == '\0')
 		errx(1, "%s", ORDER_USAGE);
 
 	if ((opts.set_inactive || opts.set_active) && !opts.has_bootnum)


More information about the svn-src-all mailing list