svn commit: r364438 - in head/cddl: contrib/opensolaris/lib/libdtrace/common usr.sbin/dtrace/tests/tools

[Mark Johnston]

On Sat, Aug 22, 2020 at 12:40:49PM +0200, Antoine Brodin wrote:
> On Thu, Aug 20, 2020 at 9:28 PM Mark Johnston <markj at freebsd.org> wrote:
> >
> > Author: markj
> > Date: Thu Aug 20 19:28:19 2020
> > New Revision: 364438
> > URL: https://svnweb.freebsd.org/changeset/base/364438
> >
> > Log:
> >   Enable creation of static userspace probes in incremental builds.
> >
> >   To define USDT probes, dtrace -G makes use of relocations for undefined
> >   symbols: the target address is overwritten with NOPs and the location is
> >   recorded in the DOF section of the output object file.  To avoid link
> >   errors, the original relocation is destroyed.  However, this means that
> >   the same input object file cannot be processed multiple times, as
> >   happens during incremental rebuilds.  Instead, only set the relocation
> >   type to NONE, so that all information required to reconstruct USDT
> >   probes is preserved.
> >
> >   Reported by:  bdrewery
> >   MFC after:    3 weeks
> >   Sponsored by: The FreeBSD Foundation
> >
> > Modified:
> >   head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_link.c
> >   head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_strtab.c
> >   head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_strtab.h
> >   head/cddl/usr.sbin/dtrace/tests/tools/exclude.sh
> 
> Hi,
> 
> This change seems broken on i386:
> 
> http://beefy17.nyi.freebsd.org/data/head-i386-default/p545731_s364466/logs/perl5-devel-5.33.0.262.log
> http://beefy17.nyi.freebsd.org/data/head-i386-default/p545731_s364466/logs/perl5.28-5.28.3.log
> http://beefy17.nyi.freebsd.org/data/head-i386-default/p545731_s364466/logs/perl5.30-5.30.3.log
> http://beefy17.nyi.freebsd.org/data/head-i386-default/p545731_s364466/logs/perl5-5.32.0.log

The links are dead, but I think the problem should be fixed by r364483.

> 
> Cheers,
> 
> Antoine