svn commit: r364340 - in head/sys/amd64: include vmm vmm/intel

Konstantin Belousov kostikbel at gmail.com
Tue Aug 18 08:48:27 UTC 2020


On Tue, Aug 18, 2020 at 07:23:47AM +0000, Peter Grehan wrote:
> +void
> +vmx_msr_guest_exit_tsc_aux(struct vmx *vmx, int vcpuid)
> +{
> +	uint64_t guest_tsc_aux = vmx->guest_msrs[vcpuid][IDX_MSR_TSC_AUX];
> +	uint32_t cpuid = PCPU_GET(cpuid);
> +
> +	if (vmx_have_msr_tsc_aux(vmx) && (guest_tsc_aux != cpuid))
This is quite unobvious place to look at if host TSC_AUX is ever going
to provide something different from cpuid.

Could you please add a comment at
{i386/i386,amd64/amd64}/initcpu.c::initializecpu() around TSC_AUX
settings pointing out this code ?


More information about the svn-src-all mailing list