svn commit: r363959 - head/sys/kern

[Mark Johnston]

Author: markj
Date: Thu Aug  6 15:42:59 2020
New Revision: 363959
URL: https://svnweb.freebsd.org/changeset/base/363959

Log:
  Remove the vfs.reassignbufcalls counter and sysctl.
  
  As the 20-year old comment above it suggests, the counter is of dubious
  value.  Moreover, the (global) counter was not updated precisely and
  hurts scalability.
  
  Reviewed by:	cem, kib, mjg
  MFC after:	1 week
  Sponsored by:	The FreeBSD Foundation
  Differential Revision:	https://reviews.freebsd.org/D25965

Modified:
  head/sys/kern/vfs_subr.c

Modified: head/sys/kern/vfs_subr.c
==============================================================================
--- head/sys/kern/vfs_subr.c	Thu Aug  6 15:25:11 2020	(r363958)
+++ head/sys/kern/vfs_subr.c	Thu Aug  6 15:42:59 2020	(r363959)
@@ -206,15 +206,6 @@ static counter_u64_t recycles_free_count;
 SYSCTL_COUNTER_U64(_vfs, OID_AUTO, recycles_free, CTLFLAG_RD, &recycles_free_count,
     "Number of free vnodes recycled to meet vnode cache targets");
 
-/*
- * Various variables used for debugging the new implementation of
- * reassignbuf().
- * XXX these are probably of (very) limited utility now.
- */
-static int reassignbufcalls;
-SYSCTL_INT(_vfs, OID_AUTO, reassignbufcalls, CTLFLAG_RW | CTLFLAG_STATS,
-    &reassignbufcalls, 0, "Number of calls to reassignbuf");
-
 static counter_u64_t deferred_inact;
 SYSCTL_COUNTER_U64(_vfs, OID_AUTO, deferred_inact, CTLFLAG_RD, &deferred_inact,
     "Number of times inactive processing was deferred");
@@ -2732,7 +2723,6 @@ reassignbuf(struct buf *bp)
 
 	vp = bp->b_vp;
 	bo = bp->b_bufobj;
-	++reassignbufcalls;
 
 	CTR3(KTR_BUF, "reassignbuf(%p) vp %p flags %X",
 	    bp, bp->b_vp, bp->b_flags);