svn commit: r363862 - head/sys/cam/mmc

[Bjoern A. Zeeb]

On 4 Aug 2020, at 20:04, Emmanuel Vadot wrote:

> Author: manu
> Date: Tue Aug  4 20:04:00 2020
> New Revision: 363862
> URL: https://svnweb.freebsd.org/changeset/base/363862
>
> Log:
>   mmccam: Hold the periph during init
>
>   We need to sleep during this routine so acquire the cam hold too.

Turns out that with this my /dev/sddaX.. device nodes are never created.
Reverting this and things work a lot better again.


>
>   Reviewed by:	imp
>   Differential Revision:	https://reviews.freebsd.org/D25946
>
> Modified:
>   head/sys/cam/mmc/mmc_da.c
>
> Modified: head/sys/cam/mmc/mmc_da.c
> ==============================================================================
> --- head/sys/cam/mmc/mmc_da.c	Tue Aug  4 20:02:23 2020	(r363861)
> +++ head/sys/cam/mmc/mmc_da.c	Tue Aug  4 20:04:00 2020	(r363862)
> @@ -1109,7 +1109,9 @@ sdda_start_init_task(void *context, int pending) 
> {
>  		      CAM_PRIORITY_NONE);
>
>  	cam_periph_lock(periph);
> +	cam_periph_hold(periph, PRIBIO|PCATCH);
>  	sdda_start_init(context, new_ccb);
> +	cam_periph_unhold(periph);
>  	cam_periph_unlock(periph);
>  	xpt_free_ccb(new_ccb);
>  }