svn commit: r360310 - stable/12/sys/dev/sound/pci/hda

Ed Maste emaste at FreeBSD.org
Sat Apr 25 15:29:07 UTC 2020


Author: emaste
Date: Sat Apr 25 15:29:06 2020
New Revision: 360310
URL: https://svnweb.freebsd.org/changeset/base/360310

Log:
  MFC r359777: hdac: show which command timed out
  
  There are several reports of "hdac0: Command timeout on address 2"
  messages emitted during playback on a variety of contemporary machines.
  Show the command that timed out in case it might provide a clue in
  finding the cause.
  
  PR:		229190
  Sponsored by:	The FreeBSD Foundation

Modified:
  stable/12/sys/dev/sound/pci/hda/hdac.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/dev/sound/pci/hda/hdac.c
==============================================================================
--- stable/12/sys/dev/sound/pci/hda/hdac.c	Sat Apr 25 15:27:45 2020	(r360309)
+++ stable/12/sys/dev/sound/pci/hda/hdac.c	Sat Apr 25 15:29:06 2020	(r360310)
@@ -996,7 +996,8 @@ hdac_send_command(struct hdac_softc *sc, nid_t cad, ui
 	} while (sc->codecs[cad].pending != 0 && --timeout);
 
 	if (sc->codecs[cad].pending != 0) {
-		device_printf(sc->dev, "Command timeout on address %d\n", cad);
+		device_printf(sc->dev, "Command 0x%08x timeout on address %d\n",
+		    verb, cad);
 		sc->codecs[cad].pending = 0;
 	}
 


More information about the svn-src-all mailing list