svn commit: r360098 - head/sys/netpfil/pf

[Kristof Provost]

Author: kp
Date: Sun Apr 19 16:10:20 2020
New Revision: 360098
URL: https://svnweb.freebsd.org/changeset/base/360098

Log:
  pf: Improve ioctl() input validation
  
  Both DIOCCHANGEADDR and DIOCADDADDR take a struct pf_pooladdr from
  userspace. They failed to validate the dyn pointer contained in its
  struct pf_addr_wrap member structure.
  
  This triggered assertion failures under fuzz testing in
  pfi_dynaddr_setup(). Happily the dyn variable was overruled there, but
  we should verify that it's set to NULL anyway.
  
  Reported-by:	syzbot+93e93150bc29f9b4b85f at syzkaller.appspotmail.com
  Reviewed by:	emaste
  MFC after:	1 week
  Differential Revision:	https://reviews.freebsd.org/D24431

Modified:
  head/sys/netpfil/pf/pf_ioctl.c

Modified: head/sys/netpfil/pf/pf_ioctl.c
==============================================================================
--- head/sys/netpfil/pf/pf_ioctl.c	Sun Apr 19 15:37:13 2020	(r360097)
+++ head/sys/netpfil/pf/pf_ioctl.c	Sun Apr 19 16:10:20 2020	(r360098)
@@ -2643,6 +2643,10 @@ DIOCGETSTATES_full:
 			error = EINVAL;
 			break;
 		}
+		if (pp->addr.addr.p.dyn != NULL) {
+			error = EINVAL;
+			break;
+		}
 		pa = malloc(sizeof(*pa), M_PFRULE, M_WAITOK);
 		bcopy(&pp->addr, pa, sizeof(struct pf_pooladdr));
 		if (pa->ifname[0])
@@ -2739,6 +2743,10 @@ DIOCGETSTATES_full:
 		if (pca->addr.addr.type != PF_ADDR_ADDRMASK &&
 		    pca->addr.addr.type != PF_ADDR_DYNIFTL &&
 		    pca->addr.addr.type != PF_ADDR_TABLE) {
+			error = EINVAL;
+			break;
+		}
+		if (pca->addr.addr.p.dyn != NULL) {
 			error = EINVAL;
 			break;
 		}