svn commit: r359809 - head/sys/netinet
Conrad Meyer
cem at freebsd.org
Sat Apr 11 21:36:03 UTC 2020
Hi Michael,
On Sat, Apr 11, 2020 at 1:37 PM Michael Tuexen <tuexen at freebsd.org> wrote:
>
> Author: tuexen
> Date: Sat Apr 11 20:36:54 2020
> New Revision: 359809
> URL: https://svnweb.freebsd.org/changeset/base/359809
>
> Log:
> Zero out pointers for consistency.
>
> This was found by running syzkaller on an INVARIANTS kernel.
For consistency? If syzkaller found something due to INVARIANTS
sys/queue.h debugging trashing the pointer values, masking them by
writing zeroes doesn't help. Generally, defeating the kernel's
INVARIANTS system is not wise or useful.
In this use, consider using
'TAILQ_CONCAT(&stcb->asoc.strmout[i].outqueue, &oldstream[i].outqueue,
next)' instead of the loop construct.
Conrad
More information about the svn-src-all
mailing list