svn commit: r359685 - in head: . etc lib/libc/gen share/mk share/termcap usr.bin/login usr.bin/vgrind usr.sbin/services_mkdb

[Maxim Sobolev]

Well, how many FreeBSD builds have you run in the last year, Rodney,
personally to care about 0.1s slowdown that it might have caused? We've run
at least a 1,000 here, probably 3x more. So yes, the cost is there, the
cost is well understood and found negligible versus the benefit of having a
slightly more extensible build system that is slightly easier to understand
and integrate into bigger projects.

-Max

On Wed, Apr 8, 2020 at 5:12 PM Rodney W. Grimes <freebsd at gndrsh.dnsmgr.net>
wrote:

> > On Tue, Apr 7, 2020 at 3:37 AM Rodney W. Grimes <
> freebsd at gndrsh.dnsmgr.net>
> > wrote:
> >
> > > > Author: sobomax
> > > > Date: Tue Apr  7 02:46:22 2020
> > > > New Revision: 359685
> > > > URL: https://svnweb.freebsd.org/changeset/base/359685
> > > >
> > > > Log:
> > > >   Normalize deployment tools usage and definitions by putting into
> one
> > > place
> > > >   instead of sprinkling them out over many disjoint files. This is a
> > > follow-up
> > > >   to achieve the same goal in an incomplete rev.348521.
> > >
> > > I have concerns that this factoring out of 5 values that have not
> changed
> > > in 25 years is a pessimization, it is one more file that make has to
> > > open on each invocation.
> > >
> >
> > Well, luckily enough the cost of opening a file has been exponentially
> > declining over those 25 years, so we are probably many-orders of
> magnitude
> > faster than  we used to be back in 1995. Or so I've heard. :)
>
> I believe we are pretty much just on par and no more than 1
> order of magnitude on time completion of make world.
>
> >
> > Having those variables defined in a centralized manner allows us here for
> > example to convert the result of what would be
> > installworld/installkernel/distribution action into a self-extracting
> > archive (optionally signed) with automatically generated script, which
> does
> > the action in question. As such, we can now build in a completely
> sandboxed
> > environment with 0 privileges (potentially even on something completely
> > alien like GNU/Linux) and then deploy it to as many systems as we need or
> > use to create VM images / Jails.
> >
> >
> https://github.com/sobomax/sysmaker/blob/master/makeargs/distribution.sub
> >
> https://github.com/sobomax/sysmaker/blob/master/makeargs/installkernel.sub
> >
> https://github.com/sobomax/sysmaker/blob/master/makeargs/installworld.sub
>
> I do not see anything in that set of files that requires this change,
> am I missing something?
>
> All of the existing values should of been overridable from the make
> command line invocation, and it does not mater if they are in 1
> file or 50 files.
>
> > I have very few reasons to believe that our needs to be unique in this, I
> > am pretty sure others will find some interesting use for this as well
> (e.g.
> > signing binaries being installed, etc).
>
> I do not see that your needs require this change.
>
> >
> > -Max
>
> --
> Rod Grimes
> rgrimes at freebsd.org
>
>