svn commit: r352847 - head/sys/arm64/arm64

Alan Cox alc at FreeBSD.org
Sat Sep 28 17:16:04 UTC 2019


Author: alc
Date: Sat Sep 28 17:16:03 2019
New Revision: 352847
URL: https://svnweb.freebsd.org/changeset/base/352847

Log:
  Eliminate redundant calls to critical_enter() and critical_exit() from
  pmap_update_entry().  It suffices that interrupts are blocked.
  
  Reviewed by:	andrew, markj
  MFC after:	1 week
  Differential Revision:	https://reviews.freebsd.org/D21753

Modified:
  head/sys/arm64/arm64/pmap.c

Modified: head/sys/arm64/arm64/pmap.c
==============================================================================
--- head/sys/arm64/arm64/pmap.c	Sat Sep 28 17:15:48 2019	(r352846)
+++ head/sys/arm64/arm64/pmap.c	Sat Sep 28 17:16:03 2019	(r352847)
@@ -3007,7 +3007,6 @@ pmap_update_entry(pmap_t pmap, pd_entry_t *pte, pd_ent
 	 * as they may make use of an address we are about to invalidate.
 	 */
 	intr = intr_disable();
-	critical_enter();
 
 	/*
 	 * Clear the old mapping's valid bit, but leave the rest of the entry
@@ -3021,7 +3020,6 @@ pmap_update_entry(pmap_t pmap, pd_entry_t *pte, pd_ent
 	pmap_store(pte, newpte);
 	dsb(ishst);
 
-	critical_exit();
 	intr_restore(intr);
 }
 


More information about the svn-src-all mailing list