svn commit: r346039 - head/sys/conf

[Warner Losh]

On Tue, Apr 9, 2019 at 11:40 AM Ian Lepore <ian at freebsd.org> wrote:

> On Tue, 2019-04-09 at 11:19 -0600, Rebecca Cran wrote:
> > On 2019-04-08 12:25, Warner Losh wrote:
> > > Author: imp
> > > Date: Mon Apr  8 18:25:14 2019
> > > New Revision: 346039
> > > URL: https://svnweb.freebsd.org/changeset/base/346039
> > >
> > > Log:
> > >    Style only change: Prefer $() to ``
> > >
> > >    $() is more modern and also nests. Convert the mix of styles to
> > > using
> > >    only the former (although the latter was more common). It's the
> > > more
> > >    dominant style in other shell scripts these days as well.
> > >
> > >    Differential Revision:  https://reviews.freebsd.org/D19840
> > >
> > > Modified:
> > >    head/sys/conf/newvers.sh
> > >
> > > Modified: head/sys/conf/newvers.sh
> >
> >
> > I thought I saw an email a few weeks ago that suggested that the list
> > of
> > people who reviewed the patch should be copied into a "Reviewed by:"
> > line, to avoid only having that information in Phabricator.
> >
> > Am I remembering correctly, or is just mentioning the Phab review
> > considered sufficient?
> >
> >
>
> As far as I'm concerned, if I've gone to all the trouble to have
> something phab-reviewed, I'm not going to waste a bunch of time hand-
> copying metadata from the review to the commit message; citing the
> review is sufficient.
>

There's that too....

Project norms here have a gap between what people expect to happen, and
what actually happens. This is orthogonal to the whole uselessly duplicated
metadata issue causing friction.

Warner