svn commit: r345900 - head/sbin/fsck_msdosfs

Ed Maste emaste at freebsd.org
Tue Sep 3 14:06:42 UTC 2019


On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes <freebsd at gndrsh.dnsmgr.net> wrote:
>

> > +static const u_char dot_name[] = {
> > +     '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' };
> > +static const u_char dotdot_name[] = {
> > +     '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' };
> > +
>
> Does it make since to encode these as hex or octal constants,
> one can not tell that those are different values in an easy
> manner.  They all look like '.' in the diff, and probably
> in most editors.

They are all either '.' or ' ', the commas are just list separators.
IMO spaces after the commas would make it slightly easier to see.




More information about the svn-src-all mailing list