svn commit: r345860 - vendor/Juniper/libxo

[Phil Shafer]

On 3 Apr 2019, at 23:07, Enji Cooper wrote:
> I could be wrong, but I’m guessing `GMAKE` needs to be replaced with 
> `MAKE`..?

GMAKE is set inside the import script, where MAKE=gmake is for 
configure.

> Also, why does a configure script need gmake? It seems like the 
> snippets that make libxo should be made more portable with autoconf, 
> if that’s the case.

configure uses gmake to build dependencies, but assumes "make" means 
gmake (${MAKE-make}).  When it finds real make instead it will complain:

     Something went wrong bootstrapping makefile fragments
     for automatic dependency tracking.  Try re-running configure with 
the
     '--disable-dependency-tracking' option to at least be able to build
     the package (albeit without support for automatic dependency 
tracking).
     See `config.log' for more details

The autoconf tools are increasingly linux-centric, so the MAKE=gmake is 
needed for BSD platforms.  Longer term, I will probably move away from 
them, as more problems are appearing.  For example, libtool is not 
naming test executables "lt-text_01.test", which makes the output of 
"make test" different under linux (since error messages include argv[0]. 
  So now I need to call xo_program() to explicitly set the name.  
Eventually cost(work-arounds) > cost(requiring-bmake).

Thanks,
  Phil