svn commit: r353507 - head/sys/dev/usb/wlan

Gleb Smirnoff glebius at FreeBSD.org
Mon Oct 14 20:26:54 UTC 2019


Author: glebius
Date: Mon Oct 14 20:26:53 2019
New Revision: 353507
URL: https://svnweb.freebsd.org/changeset/base/353507

Log:
  Convert to if_foreach_llmaddr() KPI.
  
  Reviewed by:	hselasky

Modified:
  head/sys/dev/usb/wlan/if_rsu.c

Modified: head/sys/dev/usb/wlan/if_rsu.c
==============================================================================
--- head/sys/dev/usb/wlan/if_rsu.c	Mon Oct 14 20:26:17 2019	(r353506)
+++ head/sys/dev/usb/wlan/if_rsu.c	Mon Oct 14 20:26:53 2019	(r353507)
@@ -857,6 +857,18 @@ rsu_get_multi_pos(const uint8_t maddr[])
 	return (pos);
 }
 
+static u_int
+rsu_hash_maddr(void *arg, struct sockaddr_dl *sdl, u_int cnt)
+{
+	uint32_t *mfilt = arg;
+	uint8_t pos;
+
+	pos = rsu_get_multi_pos(LLADDR(sdl));
+	mfilt[pos / 32] |= (1 << (pos % 32));
+
+	return (1);
+}
+
 static void
 rsu_set_multi(struct rsu_softc *sc)
 {
@@ -868,28 +880,13 @@ rsu_set_multi(struct rsu_softc *sc)
 	/* general structure was copied from ath(4). */
 	if (ic->ic_allmulti == 0) {
 		struct ieee80211vap *vap;
-		struct ifnet *ifp;
-		struct ifmultiaddr *ifma;
 
 		/*
 		 * Merge multicast addresses to form the hardware filter.
 		 */
 		mfilt[0] = mfilt[1] = 0;
-		TAILQ_FOREACH(vap, &ic->ic_vaps, iv_next) {
-			ifp = vap->iv_ifp;
-			if_maddr_rlock(ifp);
-			CK_STAILQ_FOREACH(ifma, &ifp->if_multiaddrs, ifma_link) {
-				caddr_t dl;
-				uint8_t pos;
-
-				dl = LLADDR((struct sockaddr_dl *)
-				    ifma->ifma_addr);
-				pos = rsu_get_multi_pos(dl);
-
-				mfilt[pos / 32] |= (1 << (pos % 32));
-			}
-			if_maddr_runlock(ifp);
-		}
+		TAILQ_FOREACH(vap, &ic->ic_vaps, iv_next)
+			if_foreach_llmaddr(vap->iv_ifp, rsu_hash_maddr, &mfilt);
 	} else
 		mfilt[0] = mfilt[1] = ~0;
 


More information about the svn-src-all mailing list