svn commit: r351934 - in head/sys: netinet netinet/tcp_stacks sys
Brad Davis
brd at FreeBSD.org
Tue Oct 1 22:13:27 UTC 2019
On Fri, Sep 6, 2019, at 8:25 AM, Randall Stewart wrote:
> Author: rrs
> Date: Fri Sep 6 14:25:41 2019
> New Revision: 351934
> URL: https://svnweb.freebsd.org/changeset/base/351934
>
> Log:
> This adds the final tweaks to LRO that will now allow me
> to add BBR. These changes make it so you can get an
> array of timestamps instead of a compressed ack/data segment.
> BBR uses this to aid with its delivery estimates. We also
> now (via Drew's suggestions) will not go to the expense of
> the tcb lookup if no stack registers to want this feature. If
> HPTS is not present the feature is not present either and you
> just get the compressed behavior.
Hi Randall,
This (+ the fixes in r351950, r351951, r351952) break TCP over a VLAN interface for me.
15:57:27.437022 IP (tos 0x0, ttl 64, id 0, offset 0, flags [DF], proto TCP (6), length 64)
192.168.1.247.51621 > 192.168.1.31.22: Flags [S], cksum 0x829c (correct), seq 954393965, win 65535, options [mss 1460,nop,wscale 6,nop,nop,TS val 1140851693 ecr 0,sackOK,eol], length 0
15:57:27.437055 IP (tos 0x0, ttl 64, id 0, offset 0, flags [DF], proto TCP (6), length 60, bad cksum 0 (->b655)!)
192.168.1.31.22 > 192.168.1.247.51621: Flags [S.], cksum 0x8495 (incorrect -> 0x7d08), seq 532354280, ack 954393966, win 65535, options [mss 1460,nop,wscale 6,sackOK,TS val 1641644043 ecr 1140851693], length 0
15:57:27.449358 IP (tos 0x0, ttl 64, id 0, offset 0, flags [DF], proto TCP (6), length 90, bad cksum 0 (->b637)!)
192.168.1.31.22 > 192.168.1.247.51621: Flags [P.], cksum 0x84b3 (incorrect -> 0xe69e), seq 1:39, ack 1, win 1026, options [nop,nop,TS val 1641644055 ecr 1140851693], length 38
15:58:00.363155 IP (tos 0x0, ttl 64, id 0, offset 0, flags [DF], proto TCP (6), length 52, bad cksum 0 (->b65d)!)
192.168.1.31.22 > 192.168.1.247.51619: Flags [.], cksum 0x848d (incorrect -> 0x98dd), seq 733444611, ack 2137820470, win 1026, options [nop,nop,TS val 3639423932 ecr 1140820150], length 0
15:58:30.078521 IP (tos 0x0, ttl 64, id 0, offset 0, flags [DF], proto TCP (6), length 52, bad cksum 0 (->b65d)!)
192.168.1.31.22 > 192.168.1.247.51621: Flags [.], cksum 0x848d (incorrect -> 0xb2f9), seq 39, ack 1, win 1026, options [nop,nop,TS val 1641706684 ecr 1140851693], length 0
Disabling LRO fixes it. Let me know if I can provide any more information.
Thanks,
Brad Davis
More information about the svn-src-all
mailing list