svn commit: r354796 - head/usr.sbin/i2c

Alex Richardson arichardson at FreeBSD.org
Sun Nov 17 19:04:03 UTC 2019


Author: arichardson
Date: Sun Nov 17 19:04:02 2019
New Revision: 354796
URL: https://svnweb.freebsd.org/changeset/base/354796

Log:
  Fix error found by new clang operator precendence warning
  
  error: operator '?:' has lower precedence than '|'; '|' will be evaluated first
  
  I discovered this in CheriBSD after updating our fork of clang to the latest
  upstream master.
  
  Reviewed By:	ian
  Differential Revision: https://reviews.freebsd.org/D22433

Modified:
  head/usr.sbin/i2c/i2c.c

Modified: head/usr.sbin/i2c/i2c.c
==============================================================================
--- head/usr.sbin/i2c/i2c.c	Sun Nov 17 18:38:37 2019	(r354795)
+++ head/usr.sbin/i2c/i2c.c	Sun Nov 17 19:04:02 2019	(r354796)
@@ -590,7 +590,7 @@ i2c_rdwr_transfer(char *dev, struct options i2c_opt, c
 	 * because of the NOSTOP flag used above.
 	 */
 	if (i2c_opt.dir == 'w')
-		msgs[i].flags = IIC_M_WR | (i > 0) ? IIC_M_NOSTART : 0;
+		msgs[i].flags = IIC_M_WR | ((i > 0) ? IIC_M_NOSTART : 0);
 	else
 		msgs[i].flags = IIC_M_RD;
 	msgs[i].slave = i2c_opt.addr;


More information about the svn-src-all mailing list