svn commit: r354714 - in head/sys: arm64/arm64 arm64/conf arm64/include conf

Rodney W. Grimes freebsd at gndrsh.dnsmgr.net
Sat Nov 16 10:46:15 UTC 2019


> On Thu, 2019-11-14 at 21:58 +0000, Justin Hibbits wrote:
> > Author: jhibbits
> > Date: Thu Nov 14 21:58:40 2019
> > New Revision: 354714
> > URL: https://svnweb.freebsd.org/changeset/base/354714
> > 
> > Log:
> >   Boot arm64 kernel using booti command from U-boot.
> >   
> > [...]
> > 
> > Added: head/sys/arm64/arm64/machdep_boot.c
> > =====================================================================
> > =========
> > --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> > +++ head/sys/arm64/arm64/machdep_boot.c	Thu Nov 14 21:58:40
> > 2019	(r354714)
> > @@ -0,0 +1,330 @@
> > +/*-
> > + * Copyright (c) 2019 Juniper Networks, Inc
> > + * Copyright (c) 2004 Olivier Houchard
> > + * Copyright (c) 1994-1998 Mark Brinicombe.
> > + * Copyright (c) 1994 Brini.
> > + * All rights reserved.
> > + *

This copyright as formed is ambiguous as to who is asserting
"All rights reserved", which is actually desired to not be
asserted at all on new code.

But given some of the dates on the above it is probalby important
to preserve the assertion until the author can asked it to be removed.

Proposed form:

 * Copyright (c) 2019 Juniper Networks, Inc All rights reserved.
 * Copyright (c) 2004 Olivier Houchard All rights reserved.
 * Copyright (c) 1994-1998 Mark Brinicombe. All rights reserved.
 * Copyright (c) 1994 Brini. All rights reserved.


> > 
> 
> I think this copyright list should be pared down to just Olivier
> (maybe?) and Juniper.  The Brini lines are from when this code was part
> of machdep.c that was imported from netbsd in the 2004 timeframe.  That
> import did not include any of the code that got copied into this new
> arm64 file.  The code to handle embedded dtb and parsing bootargs in
> various ABI formats was all added much more recently, 2012-2014 time
> frame.
> 
> Warner should probably add himself to the copyrights though, I'm pretty
> sure he's the one who wrote the various flavors of bootargs parsers.
> 
> -- Ian
> 
> 
> 

-- 
Rod Grimes                                                 rgrimes at freebsd.org


More information about the svn-src-all mailing list