svn commit: r354458 - head/libexec/rc/rc.d

[Alexander Leidinger]

Quoting Edward Tomasz Napierala <trasz at freebsd.org> (from Thu, 7 Nov  
2019 18:15:24 +0000 (UTC)):

> Author: trasz
> Date: Thu Nov  7 18:15:24 2019
> New Revision: 354458
> URL: https://svnweb.freebsd.org/changeset/base/354458
>
> Log:
>   Extend the linux rc script to mount the neccessary file systems,
>   set ELF fallback brand, and load pty(4).

We never did something like that. We have it documented everywhere  
that it needs to be done manually. So this is at least a POLA  
violation. It is great that the nocover option is used in the mount,  
but it's still some kind of layering violation (I may want to have  
only a subset mounted, or nothing at all).

I do not object to the functionality, but I think it needs to be  
configurable (an option to influence if the auto-mount is done or not,  
doesn't matter to me what the default behavior is, as long as it is  
configurable) and documented (UPDATING, handbook, man-pages, maybe  
even the release notes).

Bye,
Alexander.

-- 
http://www.Leidinger.net Alexander at Leidinger.net: PGP 0x8F31830F9F2772BF
http://www.FreeBSD.org    netchild at FreeBSD.org  : PGP 0x8F31830F9F2772BF
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digitale PGP-Signatur
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20191109/46b117b1/attachment.sig>