svn commit: r352312 - in head: lib/geom/nop sys/geom/nop

[Mariusz Zaborski]

Hello Chuck :)

I wonder if we shouldn't change this option a bit.
Shouldn't we have an option which says more like:

```
Specifies the number of I/O requests to allow before
setting the read and write failure rate.
```

In some cases, I don't want to have 100% of failure probabilities,
but on the early stage, I would like to allow some read/writes requests.
If the options would only specify the amount of the requests not
the failure probabilities could be used in other cases?

Those that make sens?
Mariusz

On Thu, 3 Oct 2019 at 00:08, Chuck Silvers <chs at freebsd.org> wrote:
>
> On Wed, Oct 02, 2019 at 08:11:57AM -0600, Alan Somers wrote:
> > On Fri, Sep 13, 2019 at 5:04 PM Chuck Silvers <chs at freebsd.org> wrote:
> >
> > > Author: chs
> > > Date: Fri Sep 13 23:03:56 2019
> > > New Revision: 352312
> > > URL: https://svnweb.freebsd.org/changeset/base/352312
> > >
> > > Log:
> > >   Add a "count_until_fail" option to gnop, which says to start failing
> > >   I/O requests after the given number have been allowed though.
> > >
> > >   Approved by:    imp (mentor)
> > >   Reviewed by:    rpokala kib 0mp mckusick
> > >   Sponsored by:   Netflix
> > >   Differential Revision:  https://reviews.freebsd.org/D21593
> > >
> > > Modified:
> > >   head/lib/geom/nop/geom_nop.c
> > >   head/lib/geom/nop/gnop.8
> > >   head/sys/geom/nop/g_nop.c
> > >   head/sys/geom/nop/g_nop.h
> > >
> >
> > This patch introduces a backwards-compatibility bug.  On a system with a
> > post-352312 kernel but a pre-352312 userland, the gnop command will always
> > fail with the error "gnop: Missing count_until_fail argument".
> > -Alan
>
> Thanks for pointing this out, I'll see about fixing it right away.
>
> -Chuck
> _______________________________________________
> svn-src-head at freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/svn-src-head
> To unsubscribe, send any mail to "svn-src-head-unsubscribe at freebsd.org"