svn commit: r354410 - in head/sys: dev/mgb modules/mgb

[N.J. Mann]

Hi,


I cannot comment on the code, but...

On Wednesday, November 06, 2019 19:51:41 +0000 Ed Maste <emaste at FreeBSD.org> wrote:
> Author: emaste
> Date: Wed Nov  6 19:51:40 2019
> New Revision: 354410
> URL: https://svnweb.freebsd.org/changeset/base/354410
[...]
> Added: head/sys/dev/mgb/if_mgb.c
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/sys/dev/mgb/if_mgb.c	Wed Nov  6 19:51:40 2019	(r354410)
> @@ -0,0 +1,1634 @@
> +/*-
> + * SPDX-License-Identifier: BSD-2-Clause
> + *
> + * Copyright (c) 2019 The FreeBSD Foundation, Inc.
> + *
> + * This driver was written by Gerald ND Aryeetey <gndaryee at uwaterloo.ca>
> + * under sponsorship from the FreeBSD Foundation.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + * 1. Redistributions of source code must retain the above copyright
> + *    notice, this list of conditions and the following disclaimer.
> + * 2. Redistributions in binary form must reproduce the above copyright
> + *    notice, this list of conditions and the following disclaimer in the
> + *    documentation and/or other materials provided with the distribution.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
> + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> + * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
> + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
> + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
> + * OR SERVICES; LOSS OF USE DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
> + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
> + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
> + * SUCH DAMAGE.
> + */
> +#include <sys/cdefs.h>
> +__FBSDID("$FreeBSD$");
> +
> +/*
> + * Microchip LAN7430/LAN7431 PCIe to Gigabit Ethernet Controller driver.
> + *
> + * Product information:
> + * LAN7430 https://www.microchip.com/wwwproducts/en/LAN7430
> + *   - Integrated IEEE 802.3 compliant PHY
> + * LAN7431 https://www.microchip.com/wwwproducts/en/LAN7431
> + *   - RGMII Interface
> + *
> + * This driver uses the iflib interface and the default 'ukphy' PHY driver.
> + *
> + * UNIMPLEMENTED FEATURES
> + * ----------------------
> + * A number of features supported by LAN743X device are not yet implemented in
> + * this driver:
> + *
> + * - Multiple (up to 4) RX queues support
> + *   - Just needs to remove asserts and malloc multiple `rx_ring_data`
> + *     structs based on ncpus.
> + * - RX/TX Checksum Offloading support
> + * - VLAN support
> + * - Recieve Packet Filtering (Multicast Perfect/Hash Address) support

        ^^^^^^^

Should be Receive (and all the later ones).


Cheers,
       Nick.
--