svn commit: r354305 - head/sys/dev/ichiic

Vladimir Kondratyev wulf at FreeBSD.org
Sun Nov 3 20:56:54 UTC 2019


Author: wulf
Date: Sun Nov  3 20:56:53 2019
New Revision: 354305
URL: https://svnweb.freebsd.org/changeset/base/354305

Log:
  [ig4] dump IG4_REG_COMP_PARAM1 and IG4_REG_COMP_VER registers unconditionally
  
  They appeared to be supported (although undocumented) on SkyLakes+ too.

Modified:
  head/sys/dev/ichiic/ig4_iic.c
  head/sys/dev/ichiic/ig4_reg.h

Modified: head/sys/dev/ichiic/ig4_iic.c
==============================================================================
--- head/sys/dev/ichiic/ig4_iic.c	Sun Nov  3 20:55:28 2019	(r354304)
+++ head/sys/dev/ichiic/ig4_iic.c	Sun Nov  3 20:56:53 2019	(r354305)
@@ -751,10 +751,8 @@ ig4iic_dump(ig4iic_softc_t *sc)
 	REGDUMP(sc, IG4_REG_DMA_RDLR);
 	REGDUMP(sc, IG4_REG_SDA_SETUP);
 	REGDUMP(sc, IG4_REG_ENABLE_STATUS);
-	if (sc->version == IG4_HASWELL || sc->version == IG4_ATOM) {
-		REGDUMP(sc, IG4_REG_COMP_PARAM1);
-		REGDUMP(sc, IG4_REG_COMP_VER);
-	}
+	REGDUMP(sc, IG4_REG_COMP_PARAM1);
+	REGDUMP(sc, IG4_REG_COMP_VER);
 	if (sc->version == IG4_ATOM) {
 		REGDUMP(sc, IG4_REG_COMP_TYPE);
 		REGDUMP(sc, IG4_REG_CLK_PARMS);

Modified: head/sys/dev/ichiic/ig4_reg.h
==============================================================================
--- head/sys/dev/ichiic/ig4_reg.h	Sun Nov  3 20:55:28 2019	(r354304)
+++ head/sys/dev/ichiic/ig4_reg.h	Sun Nov  3 20:56:53 2019	(r354305)
@@ -112,7 +112,7 @@
 #define IG4_REG_SDA_SETUP	0x0094	/* RW	SDA Setup */
 #define IG4_REG_ACK_GENERAL_CALL 0x0098	/* RW	I2C ACK General Call */
 #define IG4_REG_ENABLE_STATUS	0x009C	/* RO	Enable Status */
-/* Available at least on Atom SoCs and Haswell mobile. */
+/* Available at least on Atom SoCs, Haswell mobile and some Skylakes. */
 #define IG4_REG_COMP_PARAM1	0x00F4	/* RO	Component Parameter */
 #define IG4_REG_COMP_VER	0x00F8	/* RO	Component Version */
 /* Available at least on Atom SoCs */


More information about the svn-src-all mailing list