svn commit: r348366 - head/sys/dev/ips

Li-Wen Hsu lwhsu at FreeBSD.org
Wed May 29 18:11:18 UTC 2019


Author: lwhsu
Date: Wed May 29 18:11:17 2019
New Revision: 348366
URL: https://svnweb.freebsd.org/changeset/base/348366

Log:
  Add the likely missing braces in ips(4).  This is found by gcc warning that
  the code is not guarded by the if clause and has misleading indentation.
  
  Approved by:	scottl
  MFC after:	3 days
  Sponsored by:	The FreeBSD Foundation
  Differential Revision:	https://reviews.freebsd.org/D20427

Modified:
  head/sys/dev/ips/ips.c

Modified: head/sys/dev/ips/ips.c
==============================================================================
--- head/sys/dev/ips/ips.c	Wed May 29 16:39:52 2019	(r348365)
+++ head/sys/dev/ips/ips.c	Wed May 29 18:11:17 2019	(r348366)
@@ -287,10 +287,11 @@ static int ips_diskdev_free(ips_softc_t *sc)
 	int i;
 	int error = 0;
 	for(i = 0; i < IPS_MAX_NUM_DRIVES; i++){
-		if(sc->diskdev[i])
+		if(sc->diskdev[i]) {
 			error = device_delete_child(sc->dev, sc->diskdev[i]);
 			if(error)
 				return error;
+		}
 	}
 	bus_generic_detach(sc->dev);
 	return 0;


More information about the svn-src-all mailing list