svn commit: r347968 - head/sys/kern

[Yoshihiro Ota]

Hi Konstantin,

I coundn't remount ro->rw a few days ago.
This change isn't related, then.
I will check/tesst it again later, then.

Thanks,
Hiro

On Sun, 19 May 2019 20:51:04 +0300
Konstantin Belousov <kostikbel at gmail.com> wrote:

> On Sun, May 19, 2019 at 11:52:28AM -0400, Yoshihiro Ota wrote:
> > Hi,
> > 
> > Does this change fix 'mount -u -rw /path' to remount read-only device with write mode?
> > I moticed an issue a couple of days ago but didn't have time to conform nor report.
> 
> I do not understand your description.  If you mean does this commit has
> any relevance to the issue of remounting ro->rw, it should not.  It only
> affects rw->ro remounts, when you have a binary executed from the mount
> point.
> 
> > 
> > Thanks,
> > Hiro
> > 
> > On Sun, 19 May 2019 09:18:10 +0000 (UTC)
> > Konstantin Belousov <kib at FreeBSD.org> wrote:
> > 
> > > Author: kib
> > > Date: Sun May 19 09:18:09 2019
> > > New Revision: 347968
> > > URL: https://svnweb.freebsd.org/changeset/base/347968
> > > 
> > > Log:
> > >   Fix rw->ro remount when there is a text vnode mapping.
> > >   
> > >   Reported and tested by:	hrs
> > >   Sponsored by:	The FreeBSD Foundation
> > >   MFC after:	16 days
> > > 
> > > Modified:
> > >   head/sys/kern/vfs_subr.c
> > > 
> > > Modified: head/sys/kern/vfs_subr.c
> > > ==============================================================================
> > > --- head/sys/kern/vfs_subr.c	Sun May 19 06:01:11 2019	(r347967)
> > > +++ head/sys/kern/vfs_subr.c	Sun May 19 09:18:09 2019	(r347968)
> > > @@ -3146,7 +3146,7 @@ loop:
> > >  
> > >  			if ((vp->v_type == VNON ||
> > >  			    (error == 0 && vattr.va_nlink > 0)) &&
> > > -			    (vp->v_writecount == 0 || vp->v_type != VREG)) {
> > > +			    (vp->v_writecount <= 0 || vp->v_type != VREG)) {
> > >  				VOP_UNLOCK(vp, 0);
> > >  				vdropl(vp);
> > >  				continue;
> > > _______________________________________________
> > > svn-src-all at freebsd.org mailing list
> > > https://lists.freebsd.org/mailman/listinfo/svn-src-all
> > > To unsubscribe, send any mail to "svn-src-all-unsubscribe at freebsd.org"